✨ Quality: Ignore decorators in throw-new-error rule#2917
Open
tang-vu wants to merge 1 commit intosindresorhus:mainfrom
Open
✨ Quality: Ignore decorators in throw-new-error rule#2917tang-vu wants to merge 1 commit intosindresorhus:mainfrom
throw-new-error rule#2917tang-vu wants to merge 1 commit intosindresorhus:mainfrom
Conversation
The `throw-new-error` rule enforces that PascalCase functions containing the word "Error" are called with `new`. However, decorator factories like `@RegisterServiceError()` are conventionally PascalCase and should not require `new`. We need to exclude `CallExpression`s that are the direct child of a `Decorator` node from being evaluated by this rule. Affected files: throw-new-error.js Signed-off-by: Tang Vu <vuminhtang2212@gmail.com>
github-actions
Bot
changed the title
throw-new-error rule
Owner
|
This looks correct to me, but I think it needs a regression test before merging. |
sindresorhus
force-pushed
the
main
branch
4 times, most recently
from
814b622 to
0e023e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Code Quality
Problem
The
throw-new-errorrule enforces that PascalCase functions containing the word "Error" are called withnew. However, decorator factories like@RegisterServiceError()are conventionally PascalCase and should not requirenew. We need to excludeCallExpressions that are the direct child of aDecoratornode from being evaluated by this rule.Severity:
highFile:
rules/throw-new-error.jsSolution
The
throw-new-errorrule enforces that PascalCase functions containing the word "Error" are called withnew. However, decorator factories like@RegisterServiceError()are conventionally PascalCase and should not requirenew. We need to excludeCallExpressions that are the direct child of aDecoratornode from being evaluated by this rule.Changes
rules/throw-new-error.js(modified)🤖 About this PR
This pull request was generated by ContribAI, an AI agent
that helps improve open source projects. The change was:
If you have questions or feedback about this PR, please comment below.
We appreciate your time reviewing this contribution!
Closes #2360