Add prefer-iterator-to-array-at-end rule#2938
Open
nami8824 wants to merge 2 commits intosindresorhus:mainfrom
Open
Add prefer-iterator-to-array-at-end rule#2938nami8824 wants to merge 2 commits intosindresorhus:mainfrom
prefer-iterator-to-array-at-end rule#2938nami8824 wants to merge 2 commits intosindresorhus:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2767
What
Adds a new rule that enforces calling
.toArray()at the end of an iterator method chain, rather than in the middle.Notes
flatMapis intentionally excluded:Iterator#flatMaprequires the callback to return an iterable, whileIterator#flatMaprequires the callback to return an iterable, whereasArray#flatMapdoes not.Array#filter/mappasses a third argument (the array itself), butIterator#filter/mapdoes not.