Add a series of technical guides to the project#1162
Add a series of technical guides to the project#1162sugmanue wants to merge 1 commit intosmithy-lang:mainfrom
Conversation
| I input, ApiOperation<I, O> operation, RequestOverrideConfig overrideConfig) | ||
| ``` | ||
|
|
||
| This is the entry point for all RPC calls: |
There was a problem hiding this comment.
Hey @sugmanue, may I ask your/the team vision this method. Currently it is marked as protected and I understand that the main purpose of this is to allow derived "impl" classes to call it, but also in theory it is possible to override it during the codegen to have some extra logic in it (and still call the original method from the base-class):
<I extends SerializableStruct, O extends SerializableStruct> O call(
I input,
ApiOperation<I, O> operation,
RequestOverrideConfig overrideConfig
) {
// some logic here
return super.call(input, operation, overrideConfig);
}If you think that this is a possibility, would it be possible to expose RequestOverrideConfig fields to external consumers (or at least context getter)? Currently every getter in this class is package-private so it is not possible to access them from the outside (e.g. to get the context which was previously set by custom settings set by defaultSettings (similar to
smithy-java/examples/dynamodb-client/smithy-build.json
Lines 9 to 11 in b9d6559
Thanks!
Issue #, if available:
Add a series of technical guides to the project
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.