Add 'censor middle only' feature#35
Closed
emso-c wants to merge 1 commit into
Closed
Conversation
18fada2 to
7c5cd79
Compare
Owner
|
May I ask what the use case for "middle only" censoring is ? Or is it just a personal preference ? |
Author
|
Actually we just needed a way to determine the true length of the censored text. With the current method it returns |
Owner
|
Hmm I see. I think that would be fine, to give the users more options. By the way, as #36 already includes the feature in the PR, I think we could close this one ? |
Author
|
Oh sure, sorry about that. Closing rn. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firstly, thanks for the amazing module!
I've added a censor middle only feature which censors only the middle of the texts.
Can only be used if
middle_onlyargument is set toTrueand it's set toFalseby default, so it doesn't break anything or alter the way the module works.I didn't really test edge cases that much but it passes all 30 unit tests.
Without middle_only parameter (same result with middle_only=False):
With middle_only parameter:
Also added
env/to gitignore since I was using a virtual environment, discard it if you want.