fix: bypass Next.js fetch cache for GitHub contributions API#113
Open
TanayJalan wants to merge 1 commit into
Open
fix: bypass Next.js fetch cache for GitHub contributions API#113TanayJalan wants to merge 1 commit into
TanayJalan wants to merge 1 commit into
Conversation
|
@TanayJalan is attempting to deploy a commit to the Samuel's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes an issue where the user's GitHub contribution count would remain stale even after using the Loadout refresh functionality or returning to GitCity later.
Root Cause
By default, Next.js (App Router) aggressively caches
fetchrequests across the server, including POST requests to external APIs like the GitHub GraphQL API. Because of this, the background refresh job (refreshDeveloper) was continually receiving and saving the exact same cached contribution data from the user's initial login, rather than hitting GitHub's servers for fresh data.Solution
cache: "no-store"to thefetchcall forhttps://api.github.com/graphqlinsrc/lib/github-api.ts.cache: "no-store"to the repository listfetchcalls insrc/lib/github-api.tsandsrc/app/api/dev/[username]/route.tsto ensure users' repository stats are also kept strictly up to date.This forces Next.js to bypass its internal data cache, ensuring GitCity successfully retrieves the latest GitHub data on every background refresh.
Closes #112