fix: template for random_factory imports unnecessarily#666
Merged
stephenafamo merged 2 commits intostephenafamo:mainfrom May 4, 2026
Merged
fix: template for random_factory imports unnecessarily#666stephenafamo merged 2 commits intostephenafamo:mainfrom
stephenafamo merged 2 commits intostephenafamo:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens the bobfactory_random template logic so type imports are only added when a random expression is actually emitted, avoiding unused imports in generated random factory code.
Changes:
- Move
$.Types.Get(which triggers type imports) to occur only after confirmingRandomExprexists for the type.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Add a note to CHANGELOG.md |
Contributor
Author
|
@stephenafamo done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This narrows the random factory template import condition so it only imports when the generated code actually needs the dependency.
Why
The previous template condition could include an unnecessary import in generated random factory code.
Validation
go test ./gen