Skip to content

Update to fparser 0.2.4#3440

Open
sergisiso wants to merge 13 commits into
masterfrom
test_fparser
Open

Update to fparser 0.2.4#3440
sergisiso wants to merge 13 commits into
masterfrom
test_fparser

Conversation

@sergisiso

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a7ea7cc) to head (dd0d595).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3440   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          393       393           
  Lines        55067     55067           
=========================================
  Hits         55067     55067           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sergisiso sergisiso changed the title Update and test fparser Update to fparser 0.2.3 Jun 11, 2026
@sergisiso

Copy link
Copy Markdown
Collaborator Author

One pytest failed, I am a bit confused because adding the same fortran snippet into a file and doing: fparser2 test.f90 and psyclone test.f90 both succeed.

@arporter

Copy link
Copy Markdown
Member

One pytest failed, I am a bit confused because adding the same fortran snippet into a file and doing: fparser2 test.f90 and psyclone test.f90 both succeed.

Could it be a Python version thing?

@sergisiso

sergisiso commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

No, I am using the same environment for everything. The problem is that the test requests a fixed_form parser and the snippet is free_form. Maybe before we just ignored the syntaxerror because it starts with a blankline and we fixed this issue now.

This is not a problem in most cases because our FortranReader defaults to free_form True. But this particular tests uses the FparserReader that defaults to free_form False.

@sergisiso

Copy link
Copy Markdown
Collaborator Author

@arporter @LonelyCat124 This is ready for review

@arporter arporter added Blocked An issue/PR that is blocked by one or more issues/PRs. and removed ready for review labels Jun 16, 2026
@arporter

Copy link
Copy Markdown
Member

I suggest we pause this while we get 0.2.4 of fparser out.

@sergisiso sergisiso changed the title Update to fparser 0.2.3 Update to fparser 0.2.4 Jun 19, 2026
@sergisiso sergisiso deployed to integration June 19, 2026 13:31 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocked An issue/PR that is blocked by one or more issues/PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants