fix: add system message to signal replication ready#1962
Conversation
filipecabaco
force-pushed
the
fix/add-system-message-replication-connection
branch
2 times, most recently
from
d5b46ee to
3b3d1b0
Compare
edgurgel
left a comment
edgurgel
left a comment
There was a problem hiding this comment.
So this will only publish once right? If you join after ReplicationConnection has already started streaming it would be nice to also find out that it's replicating. Do we want to include this into the join payload that we return as well?
|
oh shit yes you are right... 🤦♂️ |
filipecabaco
force-pushed
the
fix/add-system-message-replication-connection
branch
2 times, most recently
from
8fda18f to
3e84184
Compare
filipecabaco
force-pushed
the
fix/add-system-message-replication-connection
branch
2 times, most recently
from
f6dd192 to
74e045b
Compare
This comment has been minimized.
This comment has been minimized.
filipecabaco
force-pushed
the
fix/add-system-message-replication-connection
branch
2 times, most recently
from
2ea543f to
dbfe3f2
Compare
|
I changed the approach and followed something similar to what we do for postgres changes where the channel will be the one checking. the usage of syn and pubsub can actually lead to a race condition that would mean losing this message so it would be quite bad to handle and just increases complexity to be sure things work as expected cc @edgurgel |
edgurgel
left a comment
edgurgel
left a comment
There was a problem hiding this comment.
Approving but I think this new option should be under broadcast options and not on the top level. ReplicationConnection only serves broadcast messages from realtime.messages
filipecabaco
force-pushed
the
fix/add-system-message-replication-connection
branch
from
0f20d8f to
850bc8b
Compare
|
🎉 This PR is included in version 2.111.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 participants
What kind of change does this PR introduce?
Sends a new message when replication connection starts. We only send when we receive the keep alive or a write message from the replication slot.