Skip to content

Fix KeyError when models_package is not set #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jootten wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix KeyError when models_package is not set #1219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions xsdata/formats/dataclass/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,19 @@ def is_binding_model(self, clazz: type[T]) -> bool:
if not self.class_type.is_model(clazz):
return False

return not self.models_package or (
has_valid_module = (
hasattr(clazz, "__module__")
and isinstance(clazz.__module__, str)
and clazz.__module__.startswith(self.models_package)
and clazz.__module__ in sys.modules
)

if not has_valid_module:
return False

return not self.models_package or clazz.__module__.startswith(
self.models_package
)

def find_types(self, qname: str) -> list[type[T]]:
"""Find all classes that match the given xsi:type qname.

Expand Down
Loading