fix(github-webhook): clear pending check on ok-to-test#2706
fix(github-webhook): clear pending check on ok-to-test#2706zakisk wants to merge 1 commit intotektoncd:mainfrom
Conversation
When using GitHub Webhook, the pending check run created for unauthorized PRs was never resolved after an admin commented /ok-to-test, leaving it stuck indefinitely. https://redhat.atlassian.net/browse/SRVKP-11789 Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
There was a problem hiding this comment.
Code Review
This pull request updates the logic in pkg/pipelineascode/match.go for handling /ok-to-test comments. It replaces the provider name check with a check on the InstallationID to identify GitHub Apps, ensuring that status updates are handled correctly for providers that use the checkRun API. I have no feedback to provide as there are no review comments.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2706 +/- ##
==========================================
+ Coverage 59.01% 59.12% +0.11%
==========================================
Files 208 208
Lines 20452 20512 +60
==========================================
+ Hits 12069 12127 +58
- Misses 7609 7612 +3
+ Partials 774 773 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When using GitHub Webhook, the pending check run created for unauthorized PRs was never resolved after an admin commented /ok-to-test, leaving it stuck indefinitely.
https://redhat.atlassian.net/browse/SRVKP-11789
📝 Description of the Change
🔗 Linked GitHub Issue
Fixes #
🧪 Testing Strategy
🤖 AI Assistance
AI assistance can be used for various tasks, such as code generation,
documentation, or testing.
Please indicate whether you have used AI assistance
for this PR and provide details if applicable.
Important
Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Claude noreply@anthropic.com
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.