fix: Use pull request number from issue comment payload#2711
Open
zakisk wants to merge 1 commit intotektoncd:mainfrom
Open
fix: Use pull request number from issue comment payload#2711zakisk wants to merge 1 commit intotektoncd:mainfrom
zakisk wants to merge 1 commit intotektoncd:mainfrom
Conversation
this uses the pull request number from issue commnet payload instead of doing hack to getting the number from pull request URL. Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
There was a problem hiding this comment.
Code Review
This pull request refactors the handling of pull request numbers by extracting them directly from GitHub events instead of parsing them from HTML URLs. The changes include updating the event structure to store the pull request number, removing the now-obsolete convertPullRequestURLtoNumber utility function and its associated import, and updating the test suite to reflect these structural changes. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this uses the pull request number from issue commnet payload instead of doing hack to getting the number from pull request URL.
📝 Description of the Change
🔗 Linked GitHub Issue
Fixes #
🧪 Testing Strategy
🤖 AI Assistance
AI assistance can be used for various tasks, such as code generation,
documentation, or testing.
Please indicate whether you have used AI assistance
for this PR and provide details if applicable.
Important
Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Claude noreply@anthropic.com
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.