refactor(e2e): remove reliance on Repository.Status in wait functions by zakisk · Pull Request #2789 · tektoncd/pipelines-as-code

zakisk · 2026-06-18T07:34:34Z

📝 Description of the Change

The Repository CR's Status field is deprecated and will be removed. This refactors E2E test wait helpers to use PipelineRun objects directly instead of polling Repository.Status:

Remove UntilRepositoryUpdated and UntilRepositoryHasStatusReason
Remove FailOnRepoCondition from wait.Opts
Modify UntilPipelineRunCreated and UntilPipelineRunHasReason to return []PipelineRun so callers can inspect annotations and conditions
Add UntilPipelineRunsFinished for mixed-outcome tests (1 pass + 1 fail)
Rewrite Succeeded() helper to validate PipelineRun annotations instead of repo.Status fields
Migrate all ~40 call sites across 20 test files

🔗 Linked GitHub Issue

Fixes #

🧪 Testing Strategy

🤖 AI Assistance

AI assistance can be used for various tasks, such as code generation,
documentation, or testing.

Please indicate whether you have used AI assistance
for this PR and provide details if applicable.

I have not used any AI assistance for this PR.
I have used AI assistance for this PR.

Important

Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Claude noreply@anthropic.com

✅ Submitter Checklist

gemini-code-assist

Code Review

This pull request refactors the end-to-end tests to monitor and assert on Tekton PipelineRuns directly rather than waiting for Repository status updates. The feedback highlights a recurring issue across multiple test files where the code directly accesses the Conditions slice by index (e.g., Conditions[0]) on a PipelineRun status. Since the order of conditions is not guaranteed, it is highly recommended to use GetCondition(apis.ConditionSucceeded) to safely and reliably retrieve the 'Succeeded' condition.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

gemini-code-assist · 2026-06-18T07:37:04Z

+		for _, pr := range prs.Items {
+			if len(pr.Status.Conditions) > 0 && pr.Status.Conditions[0].Status != corev1.ConditionUnknown {
+				finished = append(finished, pr)
 			}
 		}


Directly accessing the Conditions slice by index (e.g., Conditions[0]) is unreliable because the order of conditions is not guaranteed. Instead, use GetCondition(apis.ConditionSucceeded) to retrieve the 'Succeeded' condition safely.

Suggested change

for _, pr := range prs.Items {

if len(pr.Status.Conditions) > 0 && pr.Status.Conditions[0].Status != corev1.ConditionUnknown {

finished = append(finished, pr)

}

}

for _, pr := range prs.Items {

if cond := pr.Status.GetCondition(apis.ConditionSucceeded); cond != nil && cond.Status != corev1.ConditionUnknown {

finished = append(finished, pr)

}

}

References

When checking a Tekton PipelineRun's status, use GetCondition(apis.ConditionSucceeded) to reliably retrieve the 'Succeeded' condition, rather than accessing the Conditions slice by index (e.g., Conditions[0]).

gemini-code-assist · 2026-06-18T07:37:05Z

+	g.Cnx.Clients.Log.Infof("Check if pipelinerun status shows succeeded")
+	assert.Equal(t, corev1.ConditionTrue, prs[len(prs)-1].Status.Conditions[0].Status)


Directly accessing the Conditions slice by index (e.g., Conditions[0]) is unreliable because the order of conditions is not guaranteed. Instead, use GetCondition(apis.ConditionSucceeded) to retrieve the 'Succeeded' condition safely.

Suggested change

g.Cnx.Clients.Log.Infof("Check if pipelinerun status shows succeeded")

assert.Equal(t, corev1.ConditionTrue, prs[len(prs)-1].Status.Conditions[0].Status)

g.Cnx.Clients.Log.Infof("Check if pipelinerun status shows succeeded")

cond := prs[len(prs)-1].Status.GetCondition(apis.ConditionSucceeded)

assert.Assert(t, cond != nil)

assert.Equal(t, corev1.ConditionTrue, cond.Status)

References

When checking a Tekton PipelineRun's status, use GetCondition(apis.ConditionSucceeded) to reliably retrieve the 'Succeeded' condition, rather than accessing the Conditions slice by index (e.g., Conditions[0]).

gemini-code-assist · 2026-06-18T07:37:05Z

+	g.Cnx.Clients.Log.Infof("Check if we have the pipelinerun set as succeeded")
+	assert.Assert(t, prs[len(prs)-1].Status.Conditions[0].Status == corev1.ConditionTrue)


Directly accessing the Conditions slice by index (e.g., Conditions[0]) is unreliable because the order of conditions is not guaranteed. Instead, use GetCondition(apis.ConditionSucceeded) to retrieve the 'Succeeded' condition safely.

g.Cnx.Clients.Log.Infof("Check if we have the pipelinerun set as succeeded") cond := prs[len(prs)-1].Status.GetCondition(apis.ConditionSucceeded) assert.Assert(t, cond != nil) assert.Equal(t, corev1.ConditionTrue, cond.Status)

References

When checking a Tekton PipelineRun's status, use GetCondition(apis.ConditionSucceeded) to reliably retrieve the 'Succeeded' condition, rather than accessing the Conditions slice by index (e.g., Conditions[0]).

gemini-code-assist · 2026-06-18T07:37:05Z

+	g.Cnx.Clients.Log.Infof("Check if we have the pipelinerun set as succeeded")
+	lastPR := prs[len(prs)-1]
+	assert.Equal(t, lastPR.Status.Conditions[0].Status, corev1.ConditionTrue)


Directly accessing the Conditions slice by index (e.g., Conditions[0]) is unreliable because the order of conditions is not guaranteed. Instead, use GetCondition(apis.ConditionSucceeded) to retrieve the 'Succeeded' condition safely.

Suggested change

g.Cnx.Clients.Log.Infof("Check if we have the pipelinerun set as succeeded")

lastPR := prs[len(prs)-1]

assert.Equal(t, lastPR.Status.Conditions[0].Status, corev1.ConditionTrue)

g.Cnx.Clients.Log.Infof("Check if we have the pipelinerun set as succeeded")

lastPR := prs[len(prs)-1]

cond := lastPR.Status.GetCondition(apis.ConditionSucceeded)

assert.Assert(t, cond != nil)

assert.Equal(t, corev1.ConditionTrue, cond.Status)

References

When checking a Tekton PipelineRun's status, use GetCondition(apis.ConditionSucceeded) to reliably retrieve the 'Succeeded' condition, rather than accessing the Conditions slice by index (e.g., Conditions[0]).

gemini-code-assist · 2026-06-18T07:37:05Z

+	topts.ParamsRun.Clients.Log.Infof("Check if we have the pipelinerun set as succeeded")
+	lastPR := prs[len(prs)-1]
+	assert.Assert(t, lastPR.Status.Conditions[0].Status == corev1.ConditionTrue)


Directly accessing the Conditions slice by index (e.g., Conditions[0]) is unreliable because the order of conditions is not guaranteed. Instead, use GetCondition(apis.ConditionSucceeded) to retrieve the 'Succeeded' condition safely.

Suggested change

topts.ParamsRun.Clients.Log.Infof("Check if we have the pipelinerun set as succeeded")

lastPR := prs[len(prs)-1]

assert.Assert(t, lastPR.Status.Conditions[0].Status == corev1.ConditionTrue)

topts.ParamsRun.Clients.Log.Infof("Check if we have the pipelinerun set as succeeded")

lastPR := prs[len(prs)-1]

cond := lastPR.Status.GetCondition(apis.ConditionSucceeded)

assert.Assert(t, cond != nil)

assert.Equal(t, corev1.ConditionTrue, cond.Status)

References

When checking a Tekton PipelineRun's status, use GetCondition(apis.ConditionSucceeded) to reliably retrieve the 'Succeeded' condition, rather than accessing the Conditions slice by index (e.g., Conditions[0]).

gemini-code-assist · 2026-06-18T07:37:05Z

+	runcnx.Clients.Log.Infof("Check if we have the pipelinerun set as succeeded")
+	assert.Equal(t, corev1.ConditionTrue, pr.Status.Conditions[0].Status)


Directly accessing the Conditions slice by index (e.g., Conditions[0]) is unreliable because the order of conditions is not guaranteed. Instead, use GetCondition(apis.ConditionSucceeded) to retrieve the 'Succeeded' condition safely.

runcnx.Clients.Log.Infof("Check if we have the pipelinerun set as succeeded") cond := pr.Status.GetCondition(apis.ConditionSucceeded) assert.Assert(t, cond != nil) assert.Equal(t, corev1.ConditionTrue, cond.Status)

References

When checking a Tekton PipelineRun's status, use GetCondition(apis.ConditionSucceeded) to reliably retrieve the 'Succeeded' condition, rather than accessing the Conditions slice by index (e.g., Conditions[0]).

codecov · 2026-06-18T07:38:18Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.73%. Comparing base (1c0fabc) to head (b51d85b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2789   +/-   ##
=======================================
  Coverage   59.73%   59.73%           
=======================================
  Files         210      210           
  Lines       21117    21117           
=======================================
  Hits        12615    12615           
  Misses       7707     7707           
  Partials      795      795

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The Repository CR's Status field is deprecated and will be removed. This refactors E2E test wait helpers to use PipelineRun objects directly instead of polling Repository.Status: - Remove UntilRepositoryUpdated and UntilRepositoryHasStatusReason - Remove FailOnRepoCondition from wait.Opts - Modify UntilPipelineRunCreated and UntilPipelineRunHasReason to return []PipelineRun so callers can inspect annotations and conditions - Add UntilPipelineRunsFinished for mixed-outcome tests (1 pass + 1 fail) - Rewrite Succeeded() helper to validate PipelineRun annotations instead of repo.Status fields - Migrate all ~40 call sites across 20 test files Signed-off-by: Zaki Shaikh <zashaikh@redhat.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

gemini-code-assist Bot reviewed Jun 18, 2026

View reviewed changes

zakisk force-pushed the SRVKP-12156-remove-repo-status-update-in-e2e branch 2 times, most recently from b51d85b to c211bca Compare June 20, 2026 11:04

zakisk force-pushed the SRVKP-12156-remove-repo-status-update-in-e2e branch from c211bca to 51f1574 Compare June 21, 2026 11:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(e2e): remove reliance on Repository.Status in wait functions#2789

refactor(e2e): remove reliance on Repository.Status in wait functions#2789
zakisk wants to merge 1 commit into
tektoncd:mainfrom
zakisk:SRVKP-12156-remove-repo-status-update-in-e2e

zakisk commented Jun 18, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Jun 18, 2026

Uh oh!

gemini-code-assist Bot Jun 18, 2026

Uh oh!

gemini-code-assist Bot Jun 18, 2026

Uh oh!

gemini-code-assist Bot Jun 18, 2026

Uh oh!

gemini-code-assist Bot Jun 18, 2026

Uh oh!

gemini-code-assist Bot Jun 18, 2026

Uh oh!

codecov Bot commented Jun 18, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		g.Cnx.Clients.Log.Infof("Check if pipelinerun status shows succeeded")
		assert.Equal(t, corev1.ConditionTrue, prs[len(prs)-1].Status.Conditions[0].Status)

		g.Cnx.Clients.Log.Infof("Check if we have the pipelinerun set as succeeded")
		assert.Assert(t, prs[len(prs)-1].Status.Conditions[0].Status == corev1.ConditionTrue)

		runcnx.Clients.Log.Infof("Check if we have the pipelinerun set as succeeded")
		assert.Equal(t, corev1.ConditionTrue, pr.Status.Conditions[0].Status)

Conversation

zakisk commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description of the Change

🔗 Linked GitHub Issue

🧪 Testing Strategy

🤖 AI Assistance

✅ Submitter Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

zakisk commented Jun 18, 2026 •

edited

Loading

codecov Bot commented Jun 18, 2026 •

edited

Loading