Heuristic endomorphisms#2241
Open
JHanselman wants to merge 6 commits intomasterfrom
Open
Conversation
…ristic endomorphism computations
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2241 +/- ##
==========================================
- Coverage 77.49% 77.45% -0.05%
==========================================
Files 381 383 +2
Lines 120501 120738 +237
==========================================
+ Hits 93384 93517 +133
- Misses 27117 27221 +104
🚀 New features to boost your workflow:
|
File not needed yet. Part of a different future PR.
simonbrandhorst
requested changes
Apr 30, 2026
Collaborator
simonbrandhorst
left a comment
simonbrandhorst
left a comment
There was a problem hiding this comment.
Would you please add documentation to the new methods?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds code to heuristically compute homomorphisms between abelian varieties given by period matrices. It also improves the precision of the period matrix copmutations.