chore(deps): upgrade rxjs 6 → 7#114
Open
trungvose wants to merge 3 commits into
Open
Conversation
RxJS 6 has been EOL since 2022. Angular 17 through 20 all accept rxjs@^6.5.3 || ^7.4.0 via peer deps, so this isn't a hard blocker for the Angular 17 -> 20 migration, but landing it first keeps subsequent PRs focused and drops the deprecated toPromise() surface. - rxjs: 6.6.6 -> ^7.8.0 (resolved 7.8.1) - no toPromise(), Observable.create(), or legacy combineLatest spread form hits in apps/ or libs/ (defensive sweep verified) - no removed-operator surprises (no `partition` free function, no `resultSelector` arg usage) Part of the Angular 17 -> 20 migration plan: docs/plans/2026-04-18-angular-20-migration-plan.md
Captured via playwriter on the dev server after completing Spotify OAuth. Confirms the home dashboard renders (sidebar + Recently Played + Popular Playlists) on RxJS 7.8.1, NgRx effects driving the data, no console errors. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
Visual verificationCaptured via playwriter on the dev server after completing Spotify OAuth. Confirms the home dashboard renders on RxJS 7.8.1, NgRx effects still drive the data correctly, no console errors.
Source: `docs/plans/prep/evidence/prep-2.3-rxjs-7.png` |
Resolves conflicts in package.json and yarn.lock by keeping rxjs ^7.8.0 on top of the ng-zorro 17, @sentry/angular 8, and cypress-removal updates already landed on main.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
.toPromise()is deprecated; modern alternatives arefirstValueFrom/lastValueFrom.What changed
rxjs: 6.6.6 → 7.8.1.toPromise(inapps/+libs/→ 0Observable.create(→ 0combineLatest(a, b, c)spread form → 0 (all 13 sites use array form)partitionfree function → 0yarn.locknow has a single RxJS family (7.x)Validation
yarn installcleanyarn nx build angular-spotifypasses (22s, no RxJS-related errors)yarn startboots, responds on :4200Pre-existing lint and test failures were verified against `main` and are not introduced by this PR.
Part of the Angular 17 → 20 migration plan: `docs/plans/2026-04-18-angular-20-migration-plan.md`
Brief: `docs/plans/prep/2.3-rxjs-7.md`
🤖 Generated with Claude Code