Skip to content

chore: Remove unnecessary drop calls#220

Open
marc2332 wants to merge 1 commit into
mainfrom
chore/remove-unnecessary-drop-calls
Open

chore: Remove unnecessary drop calls#220
marc2332 wants to merge 1 commit into
mainfrom
chore/remove-unnecessary-drop-calls

Conversation

@marc2332

Copy link
Copy Markdown
Member

No description provided.

@github-actions

Copy link
Copy Markdown

Performance Comparison mainchore/remove-unnecessary-drop-calls

Total Elapsed Time: 43.09ms → 41.60ms (-3.5%)
CPU Baseline: 89.20µs → 89.57µs (+0.4%)
Benchmark ID: timing

timing - Execution duration of functions.

+--------------------------------------+-----------------------+---------------------------------+---------------------------------+---------------------------------+---------------------------------+--------------------------------+------------------------------+
| Function                             | Calls                 | Avg                             | P50                             | P95                             | P99                             | Total                          | % Total                      |
+--------------------------------------+-----------------------+---------------------------------+---------------------------------+---------------------------------+---------------------------------+--------------------------------+------------------------------+
| andromeda::main                      | 1 → 1 (+0.0%)         | 42.76ms → 41.30ms (-3.4%)       | 42.80ms → 41.32ms (-3.5%)       | 42.80ms → 41.32ms (-3.5%)       | 42.80ms → 41.32ms (-3.5%)       | 42.76ms → 41.30ms (-3.4%)      | 100.00% → 100.00% (+0.0%)    |
+--------------------------------------+-----------------------+---------------------------------+---------------------------------+---------------------------------+---------------------------------+--------------------------------+------------------------------+
| andromeda::run_main                  | 1 → 1 (+0.0%)         | 42.74ms → 41.28ms (-3.4%)       | 42.76ms → 41.29ms (-3.4%)       | 42.76ms → 41.29ms (-3.4%)       | 42.76ms → 41.29ms (-3.4%)       | 42.74ms → 41.28ms (-3.4%)      | 99.95% → 99.95% (+0.0%)      |
+--------------------------------------+-----------------------+---------------------------------+---------------------------------+---------------------------------+---------------------------------+--------------------------------+------------------------------+
| run::run                             | 1 → 1 (+0.0%)         | 41.93ms → 40.37ms (-3.7%)       | 41.94ms → 40.40ms (-3.7%)       | 41.94ms → 40.40ms (-3.7%)       | 41.94ms → 40.40ms (-3.7%)       | 41.93ms → 40.37ms (-3.7%)      | 98.05% → 97.76% (-0.3%)      |
+--------------------------------------+-----------------------+---------------------------------+---------------------------------+---------------------------------+---------------------------------+--------------------------------+------------------------------+
| run::run_with_config                 | 1 → 1 (+0.0%)         | 41.93ms → 40.37ms (-3.7%)       | 41.94ms → 40.40ms (-3.7%)       | 41.94ms → 40.40ms (-3.7%)       | 41.94ms → 40.40ms (-3.7%)       | 41.93ms → 40.37ms (-3.7%)      | 98.05% → 97.76% (-0.3%)      |
+--------------------------------------+-----------------------+---------------------------------+---------------------------------+---------------------------------+---------------------------------+--------------------------------+------------------------------+
| Runtime::run                         | 1 → 1 (+0.0%)         | 21.46ms → 20.45ms (-4.7%)       | 21.46ms → 20.46ms (-4.7%)       | 21.46ms → 20.46ms (-4.7%)       | 21.46ms → 20.46ms (-4.7%)       | 21.46ms → 20.45ms (-4.7%)      | 50.18% → 49.51% (-1.3%)      |
+--------------------------------------+-----------------------+---------------------------------+---------------------------------+---------------------------------+---------------------------------+--------------------------------+------------------------------+
| Runtime::new                         | 1 → 1 (+0.0%)         | 19.33ms → 18.76ms (-2.9%)       | 19.33ms → 18.76ms (-2.9%)       | 19.33ms → 18.76ms (-2.9%)       | 19.33ms → 18.76ms (-2.9%)       | 19.33ms → 18.76ms (-2.9%)      | 45.21% → 45.42% (+0.5%)      |
+--------------------------------------+-----------------------+---------------------------------+---------------------------------+---------------------------------+---------------------------------+--------------------------------+------------------------------+
| Extension::load                      | 25 → 25 (+0.0%)       | 751.71µs → 727.31µs (-3.2%)     | 296.70µs → 309.50µs (+4.3%)     | 2.79ms → 2.65ms (-5.0%)         | 5.58ms → 5.07ms (-9.1%)         | 18.79ms → 18.18ms (-3.2%)      | 43.95% → 44.03% (+0.2%)      |
+--------------------------------------+-----------------------+---------------------------------+---------------------------------+---------------------------------+---------------------------------+--------------------------------+------------------------------+
| ConsoleExt::internal_print           | 180 → 180 (+0.0%)     | 4.39µs → 4.75µs (+8.2%)         | 4.52µs → 2.07µs (-54.2%) 🚀     | 10.14µs → 15.81µs (+55.9%) ⚠️   | 12.86µs → 24.59µs (+91.2%) ⚠️   | 789.55µs → 855.96µs (+8.4%)    | 1.85% → 2.07% (+11.9%)       |
+--------------------------------------+-----------------------+---------------------------------+---------------------------------+---------------------------------+---------------------------------+--------------------------------+------------------------------+
| recommended::recommended_extensions  | 1 → 1 (+0.0%)         | 87.23µs → 52.93µs (-39.3%) 🚀   | 87.30µs → 52.96µs (-39.3%) 🚀   | 87.30µs → 52.96µs (-39.3%) 🚀   | 87.30µs → 52.96µs (-39.3%) 🚀   | 87.23µs → 52.93µs (-39.3%) 🚀  | 0.20% → 0.13% (-35.0%) 🚀    |
+--------------------------------------+-----------------------+---------------------------------+---------------------------------+---------------------------------+---------------------------------+--------------------------------+------------------------------+
| 🆕 ProcessExt::internal_get_cli_args | 0 → 1 (+100.0%) ⚠️    | 0.00ns → 15.84µs (+100.0%) ⚠️   | 0.00ns → 15.85µs (+100.0%) ⚠️   | 0.00ns → 15.85µs (+100.0%) ⚠️   | 0.00ns → 15.85µs (+100.0%) ⚠️   | 0.00ns → 15.84µs (+100.0%) ⚠️  | 0.00% → 0.04% (+100.0%) ⚠️   |
+--------------------------------------+-----------------------+---------------------------------+---------------------------------+---------------------------------+---------------------------------+--------------------------------+------------------------------+
| 🗑️ ConsoleExt::get_group_indent      | 180 → 0 (-100.0%) 🚀  | 129.00ns → 0.00ns (-100.0%) 🚀  | 110.00ns → 0.00ns (-100.0%) 🚀  | 290.00ns → 0.00ns (-100.0%) 🚀  | 531.00ns → 0.00ns (-100.0%) 🚀  | 23.34µs → 0.00ns (-100.0%) 🚀  | 0.05% → 0.00% (-100.0%) 🚀   |
+--------------------------------------+-----------------------+---------------------------------+---------------------------------+---------------------------------+---------------------------------+--------------------------------+------------------------------+

Threads

+-----------------+-----------+-----------+
| Thread          | CPU % Avg | CPU % Max |
+-----------------+-----------+-----------+
| hp-functions    |           |           |
+-----------------+-----------+-----------+
| hp-threads      |           |           |
+-----------------+-----------+-----------+
| hp-cpu-baseline |           |           |
+-----------------+-----------+-----------+

Generated with hotpath-rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant