Decoupled flyout region#59
Conversation
…primary nav is a good idea if choosing not to use the primary nav in the drawer, otherwise primary nav goes away entirely
…ter in the clf_navigation_option section
…ve right on sticky mobile
…s by creating a separate containing div for the flyout
… where secondary menu was not expanding on click
…es not poke through visually
…e drawer nav when taller than viewport
… needs to be 100% for scrolling
…g under it on mobile
… obfuscates content. This should be done dynamically on click.
joelpittet
left a comment
joelpittet
left a comment
There was a problem hiding this comment.
Any chance you could toss in a photo of what this is in the pull request?
| # Postcss-fied CSS files | ||
| postcss/ | ||
|
|
||
| .DS_Store |
There was a problem hiding this comment.
I'd suggest moving some of the clean-up changes to their own issue so they can be reviewed as one thing.
There was a problem hiding this comment.
I've pushed the changes wrt to your comments, Joel. Thanks very much for reviewing.
| </div><!-- /#content --> | ||
| </div><!-- /#main --> | ||
| <?php print $fluidcontainerend; ?> | ||
| <?php // print $fluidcontainerend; ?> |
There was a problem hiding this comment.
These comments worry me a bit, usually don't like leaving commented out code.
There was a problem hiding this comment.
We override this in our child theme because it breaks pages that want full width backgrounds, but these should be uncommented in megatron, which I've done in my flyout branch and will do in develop fork as a new pull request.
| ), | ||
| ); | ||
|
|
||
| $form['clf_navigation_option']['clf_sticky_option'] = array( |
There was a problem hiding this comment.
What happened to this hunk of code? I don't see "clf_navoption" for example in the new code hunks
There was a problem hiding this comment.
This was moved down with the other $form['clf_navigation_option'] options
| '#type' => 'checkbox', | ||
| '#title' => t('Use the primary menu in the off-canvas drawer?'), | ||
| '#description' => t('This is optional in case you want to use additonal content blocks, such as a menu block, in the off-canvas drawer region.'), | ||
| '#description' => t('If not chosen, you should use a menu block or alternate method for main navigation in the off-canvas drawer region.'), |
There was a problem hiding this comment.
I agree that the wording could use clarification, I have a hang-up on "chosen" but otherwise +1
There was a problem hiding this comment.
I changed it to "If you do not use the primary menu in the drawer, you should use a menu block or alternate method for main navigation in the off-canvas drawer region." Hope this is better.
…d overrides it in a child theme and it should be there in megatron
3 participants
Decoupled flyout region on top of drawer nav in develop branch