Skip to content

all: modernize#1276

Merged
abhinav merged 1 commit into
masterfrom
modernize
Sep 14, 2025
Merged

all: modernize#1276
abhinav merged 1 commit into
masterfrom
modernize

Conversation

@abhinav

@abhinav abhinav commented Sep 11, 2025

Copy link
Copy Markdown
Collaborator

Run the modernize linter across the codebase.
Change generated by running:

go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...

Ref: https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize

@abhinav

abhinav commented Sep 11, 2025

Copy link
Copy Markdown
Collaborator Author

This change is part of the following stack:

Change managed by git-spice.

@codecov

codecov Bot commented Sep 11, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.64%. Comparing base (21e34ec) to head (6a24101).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1276   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files          35       35           
  Lines        3458     3458           
=======================================
  Hits         3411     3411           
  Misses         40       40           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rabbbit

rabbbit commented Sep 12, 2025

Copy link
Copy Markdown

(am I meant to merge anything or do you still have powers abg? I'm also not sure about the stack thing- do you want to land it all together?)

@abhinav

abhinav commented Sep 13, 2025

Copy link
Copy Markdown
Collaborator Author

Thanks!
The stack has to be landed bottom-up, so after the bottom-most is approved, I will rebase the rest and then we can merge the new bottom-most PR, and so on.
I think I still have privileges to press merge once the PR is approved.

Base automatically changed from golangci-lint-v2 to master September 14, 2025 16:21
Run the modernize linter across the codebase.
Change generated by running:

```
go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...
```

Ref: https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize
@abhinav abhinav merged commit 6fab1b2 into master Sep 14, 2025
17 of 18 checks passed
@abhinav abhinav deleted the modernize branch September 14, 2025 16:24
@alexandear alexandear mentioned this pull request Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants