keys in did documents should list controller instead of owner#33
keys in did documents should list controller instead of owner#33
controller instead of owner#33Conversation
Codecov Report
@@ Coverage Diff @@
## develop #33 +/- ##
=============================================
+ Coverage 72.69% 73.38% +0.69%
- Complexity 181 182 +1
=============================================
Files 24 24
Lines 868 868
Branches 145 145
=============================================
+ Hits 631 637 +6
+ Misses 159 152 -7
- Partials 78 79 +1
Continue to review full report at Codecov.
|
mirceanis
left a comment
There was a problem hiding this comment.
This is a good start towards adhering to the latest W3C definitions but there are also existing DIDs out there that would fail with this proposed version.
Real-world existing web dids will crash with this change:
@Test
fun `can resolve real web did`() {
val doc = WebDidResolver().resolve("did:web:uport.me")
}Since the existing testing data was also changed, the current tests don't reflect real world behavior.
We should have a test to support parsing of older-style DIDs. This test should hardcode an old format DID doc and verify that it is resolved properly.
This problem will manifest for web-did and uport-did documents since they are stored somewhere and not generated at runtime like ethr-did
|
Adapting to legacy DID doc formats is tricky without support from the serialization lib. This PR should make it easier to completely cover the above cases: |
What's Here
This resolves the issue #29
ownerkey inDIDDocumenttocontrolleras stated in the DID specTesting
Rund the entire test suite using the command
./gradlew test cC --no-parallel