-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(cmcdv2): implement rtp, lb, dl, pb, tpb, ttfb and ttlb #7895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cotid-qualabs
wants to merge
12
commits into
video-dev:master
Choose a base branch
from
qualabs:issue/cmcdv2-bitrate-keys
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+357
−20
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3866186
implemented rtp, lb, dl, pb, ttfb and ttlb
cotid-qualabs 41faf6b
fix dl key
cotid-qualabs 38c3678
fix rtp
cotid-qualabs b48359a
fix pb
cotid-qualabs 90f95a0
implement tpb
cotid-qualabs 694bd1f
fix tpb test
cotid-qualabs f8b6207
update rtpSafetyFactor default value to match dashjs
cotid-qualabs 18e2fae
update unit test
cotid-qualabs 0b26cc1
Merge branch 'master' into issue/cmcdv2-bitrate-keys
littlespex d435f1b
Update src/controller/cmcd-controller.ts
cotid-qualabs 02de64c
resolve review comments
cotid-qualabs 4e18665
Merge branch 'master' into issue/cmcdv2-bitrate-keys
littlespex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't the response mode need to be enabled? Can we not do this when the response event is not registered to be reported?