Skip to content

Add constructor with ToastType only#993

Merged
gvreddy04 merged 1 commit into
vikramlearning:mainfrom
NathanJPhillips:ToastMessage-constructor
Jun 22, 2026
Merged

Add constructor with ToastType only#993
gvreddy04 merged 1 commit into
vikramlearning:mainfrom
NathanJPhillips:ToastMessage-constructor

Conversation

@NathanJPhillips

Copy link
Copy Markdown
Contributor

Add a constructor for ToastMessage that takes ToastType only.

With the new RenderFragment toast content a constructor that takes ToastType but not a string message now makes sense.

At the same time make some changes to other constructors:
o Invoke simpler constructors from more complex ones to avoid duplicating code
o Use default argument for autoHide instead of writing two separate constructors
o Add autoHide parameter to constructor that takes IconName to mirror the constructor that takes customIconName

@NathanJPhillips

Copy link
Copy Markdown
Contributor Author

Check failure looks unrelated to my changes. I believe it's caused by this error:
The format of the analysis property sonar.login= is invalid

@gvreddy04 gvreddy04 added this to the 4.0.0 milestone Jun 22, 2026
@gvreddy04 gvreddy04 added area-toasts enhancement New feature or request labels Jun 22, 2026

@gvreddy04 gvreddy04 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gvreddy04 gvreddy04 merged commit 38f2a3c into vikramlearning:main Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-toasts enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants