feat(VField): add placeholder slot support#22918
Open
wxj006007 wants to merge 4 commits into
Open
Conversation
- Remove unused from VTextField and VTextarea test files - Fix VTextField test description: 'should render' → 'should not render' to match assertion
Remove placeholder and persistentPlaceholder from VTextField and VTextarea prop factories since they are now inherited from makeVFieldProps() in VField, which caused TypeScript TS2783 errors. Also fix ESLint errors in VField.tsx and test files. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
placeholderslot toVField,VTextField, andVTextareacomponents, allowing users to customize placeholder content with Vue transitions and other slot features.Closes #20886
Motivation
Currently, the
placeholderprop only accepts a string, making it impossible to use Vue transitions or other dynamic content in the placeholder. The existinglabelslot already supports this pattern, and this PR extends the same approach toplaceholder.Changes
placeholderslot type definition and rendering logic.v-field__placeholderplaceholderattribute when slot is providedUsage