fix(VHighlight): add ignore-accents support#22922
Draft
J-Sek wants to merge 2 commits into
Draft
Conversation
J-Sek
added
T: feature
Adds an `ignoreAccents` prop (`boolean | 'query' | 'target'`) so matches can fold diacritics on either side. Folding is done per character with an index map, so highlight ranges stay aligned to the original text even when the source is in decomposed form. Letters NFD leaves untouched (ł, ø, ß, æ, …) are folded via an explicit map. Backed by a shared `findMatchRanges` util reused by the filter composable. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Exposes `ignoreAccents` (`boolean | 'query' | 'target'`) on the shared filter props, so VSelect, VAutocomplete, VCombobox, VDataTable and other filterable components can match accent-insensitively. `defaultFilter` now emits index-mapped match ranges, so the highlighted spans stay correct. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
J-Sek
force-pushed
the
feat/vhighlight-ignore-accents
branch
from
5706062 to
90fa23e
Compare
J-Sek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ignore-accentsprop (boolean | 'query' | 'target')resolves #22917
TODO:
{ mode, normalize }to the prop type to accept custom normalization logic... or wait for feedback since full DB collation parity may be impossible anywayMarkup: