Conversation
asp345
requested review from
Hank-Choi,
davin111 and
eastshine2741
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spotless(https://github.com/diffplug/spotless) 로 전환하고 target을
target("src/**/*.kt")로 명시해서, ktlint 실행 시 aot 처리가 도는 문제를 해결하려고 합니다포맷팅 바뀐건 ktlint 버전을 1.8.0 으로 올리면서 규칙이 바뀌어서 그래요
단점은 기본적으로는 pre-commit에 formatting하는 hook이 없고 push할때 check만 하는게 있는듯?