Skip to content

Fix events repeatableAdded/Removed not working when used in DOM template#432

Open
j0ber wants to merge 3 commits into
wearebraid:masterfrom
j0ber:master
Open

Fix events repeatableAdded/Removed not working when used in DOM template#432
j0ber wants to merge 3 commits into
wearebraid:masterfrom
j0ber:master

Conversation

@j0ber

@j0ber j0ber commented May 14, 2021

Copy link
Copy Markdown

Amazing project!
We are using it with DOM templates and are unable to use the "repeatableAdded" and "repeatableRemoved" events.

@justin-schroeder

Copy link
Copy Markdown
Member

@j0ber somehow this PR slipped under my radar. Seems like a reasonable change — for some small faction of people though this will represent a breaking change. It seems we may need to emit both events camel case and kebab. Mind making those edits and re-submitting?

@j0ber

j0ber commented Jun 22, 2021

Copy link
Copy Markdown
Author

Sure no problem.

@j0ber

j0ber commented Jun 22, 2021

Copy link
Copy Markdown
Author

Still have the infamous "error: option '-k, --key ' argument missing" with cypress... Really don't know why...

david-mears-2 added a commit to usemast/vue-formulate that referenced this pull request Mar 2, 2022
See wearebraid#432 for details. At time
of writing the PR was still open and unapproved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants