Skip to content

fix: 修复setRow会导致keyField类型变更的问题，number类型的key会变为string类型 #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ming4762 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: 修复setRow会导致keyField类型变更的问题，number类型的key会变为string类型 #2789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a94b814
fix: 修复setRow会导致keyField类型变更的问题，number类型的key会变为string类型
ming4762 Feb 21, 2025
119c7c2
perf: setRow可能更新失败：如果row不是响应性对象或者row不是从表格数据获取的响应性对象，都要导致更新失败
ming4762 Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/table/src/table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3603,7 +3603,11 @@ export default defineComponent({
const rowid = getRowid($xeTable, row)
const newRecord = XEUtils.clone(Object.assign({}, record), true)
XEUtils.set(newRecord, rowkey, rowid)
Object.assign(row, newRecord)
if (rowid !== '') {
// 如果row不是响应性对象，或者row不是从表格数据获取的响应性对象，都要导致更新失败
row = tableMethods.getRowById(rowid)
Object.assign(row, newRecord)
}
})
}
return nextTick()
Expand Down
6 changes: 5 additions & 1 deletion packages/table/src/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,11 @@ export function getRowkey ($xeTable: VxeTableConstructor) {
// 行主键 value
export function getRowid ($xeTable: VxeTableConstructor, row: any) {
const rowid = XEUtils.get(row, getRowkey($xeTable))
return XEUtils.eqNull(rowid) ? '' : encodeURIComponent(rowid)
if (XEUtils.eqNull(rowid)) {
return ''
}
const type = typeof rowid
return (type === 'number' || type === 'bigint') ? rowid : encodeURIComponent(rowid)
}

export interface XEColumnInstance {
Expand Down