Improvement: Frosted glass navbar on iPhone

[wutschel]

Description

Frosted Glass Effect

Use frosted glass effect ([UIBlurEffect effectWithStyle:UIBlurEffectStyleDark]) for navbar. Let the table views extend underneath the frosted glass and adapt contentInset accordingly.

Special care is needed for the following areas:

• To have SVPullToRefresh working as expected it is important to explicitly set contentInset instead of automatic adjustment.
• For iPad it is important to hide the toolbar's effect view buttonsViewEffect while being in fullscreen library view.

Screenshots

Screenshots (left = current, right = dark blur): https://ibb.co/zW9r4NRv
Video: link to video

Summary for release notes

Improvement: Frosted glass navbar on iPhone

[wutschel]

Initial PR only covers the library views. More work is required to let other views like server list or custom button view handle this as desired (= scroll view extending underneath the navbar) as well.

[kodiai]

severity: minor
category: correctness

Redundant configureWithOpaqueBackground call

[MINOR] The call to configureWithOpaqueBackground on line 115 is immediately overridden by configureWithTransparentBackground on line 116. The first call has no effect and should be removed. suggestion [appearance configureWithTransparentBackground];

[kodiai]

severity: medium
category: correctness

Redundant configureWithOpaqueBackground call

[MEDIUM] The refactored code sets contentInset but no longer sets scrollIndicatorInsets. When content extends under translucent bars, the scroll indicator needs matching insets to avoid being partially obscured by the navigation bar or toolbar. The removed code explicitly set both: objc moreItemsViewController.tableView.scrollIndicatorInsets = tableViewInsets; This should be added after line 1063: suggestion moreItemsViewController.tableView.contentInset = activeLayoutView.contentInset; [self setViewInset:moreItemsViewController.tableView bottom:buttonsViewBgToolbar.frame.size.height]; moreItemsViewController.tableView.scrollIndicatorInsets = moreItemsViewController.tableView.contentInset; [moreItemsViewController.tableView setContentOffset:CGPointMake(0, -moreItemsViewController.tableView.contentInset.top) animated:NO];

[kodiai]

severity: medium
category: correctness

Redundant configureWithOpaqueBackground call

[MEDIUM] When setting contentInset.top to extend content under the navigation bar, scrollIndicatorInsets should also be set to prevent the scroll indicator from being drawn underneath the navbar. The existing setViewInset:bottom: method at DetailViewController.m:860-865 demonstrates this pattern (sets both contentInset and scrollIndicatorInsets), but it's not used here. suggestion UIEdgeInsets viewInsets = dataList.contentInset; viewInsets.top = [self getTableInsetTop]; dataList.contentInset = viewInsets; dataList.scrollIndicatorInsets = viewInsets;