#53 add Transformers.Standalone to control the standalone attribute#321
Open
edmoffo wants to merge 1 commit into
Open
#53 add Transformers.Standalone to control the standalone attribute#321edmoffo wants to merge 1 commit into
edmoffo wants to merge 1 commit into
Conversation
…tion Lets callers ask the XML output to carry standalone="yes" or standalone="no" in the declaration, which has been unreachable through the existing Transformers.Document and Transformers.Compact factories. Closes yegor256#53
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
Transformers.Standalonefactory so callers can ask the XML output to carry an explicitstandalone="yes"orstandalone="no"in the declaration. Until now neitherTransformers.DocumentnorTransformers.Compactexposed that attribute, so the scenario from #53 (<?xml version="1.0" encoding="UTF-8" standalone="no"?>) was unreachable through the public API.new Xembler(directives, new Transformers.Standalone(false)).xml()now produces a declaration withstandalone="no", andStandalone(true)producesstandalone="yes". Indentation and UTF-8 encoding matchTransformers.Documentso the rest of the output is unchanged.Verified locally with
mvn -Pqulice -Dhone.skip=true clean install: the build is green, Qulice has no violations, and the two new cases inTransformersTestpass alongside the existing six tests.Closes #53