feat: HWタイムスタンプ対応・ヘッダー分割・開発基盤整備#11
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This pull request implements Linux NIC hardware timestamping with PHC (PTP Hardware Clock) integration, modularizes the header structure from a monolithic stamp.h into 5 specialized headers, and establishes comprehensive development infrastructure including static analysis tools, sanitizer presets, and extensive documentation.
Changes:
- Hardware timestamp support via
SO_TIMESTAMPINGand PHC device integration (-iand-coptions) - Header modularization: split
stamp.hintostamp_platform.h,stamp_protocol.h,stamp_time.h,stamp_kernel_ts.h,stamp_net.h, andstamp_calc.h - Development infrastructure:
.clang-format,.clang-tidy,.cppcheck-suppressions, CMake presets for ASan/UBSan, and PGO support - Documentation: new
docs/BUILD.md,docs/USAGE.md,docs/ARCHITECTURE.md, and RFC references indocs/RFC/ - Test expansion to 250+ tests with relaxed complexity thresholds in
tests/.clang-tidy
Reviewed changes
Copilot reviewed 31 out of 37 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/stamp_time.h |
Timestamp conversion functions (NTP/PTP), delay calculations, validation logic |
src/stamp_protocol.h |
Protocol constants, packet structures, Error Estimate definitions |
src/stamp_platform.h |
Platform abstraction (Windows/Linux), getopt compatibility, cleanup helpers |
src/stamp_net.h |
Signal handlers, address utilities, port parsing |
src/stamp_kernel_ts.h |
Kernel timestamp extraction, HW timestamp support, PHC integration (Linux) |
src/stamp_calc.h |
Pure calculation functions for packet construction |
src/stamp_globals.c |
Global variable definitions (g_running) |
tests/.clang-tidy |
Relaxed complexity thresholds for test code |
docs/USAGE.md |
CLI reference, usage examples, troubleshooting guide |
docs/BUILD.md |
Build instructions, platform setup, optimization options |
docs/ARCHITECTURE.md |
Technical specifications, header structure, timestamp system |
docs/LICENSE.md |
License and attribution information |
CMakeLists.txt |
Enhanced compiler flags (30+ warnings), security hardening, LTO/PGO support |
CMakePresets.json |
ASan/UBSan, portable, and PGO presets |
.clang-format |
Linux Kernel style enforcement |
.clang-tidy |
Strict naming conventions and quality checks |
.cppcheck-suppressions |
Documented suppressions for platform-specific code |
CLAUDE.md |
Project conventions and coding guidelines |
| Various docs | README updates, ROADMAP updates, CONTRIBUTING enhancements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Summary
SO_TIMESTAMPING) と PHC (PTP Hardware Clock) 連携を実装し、-i/-cオプションで利用可能にstamp.hを5つの専用ヘッダー (stamp_platform.h,stamp_protocol.h,stamp_time.h,stamp_kernel_ts.h,stamp_net.h) にモジュール分割.clang-format,.clang-tidy,.cppcheck-suppressionsなど静的解析・フォーマッター設定を追加docs/BUILD.md,docs/USAGE.md,docs/ARCHITECTURE.mdを新設し、関連RFC資料をdocs/RFC/に整理CLAUDE.mdを新設しプロジェクト規約を明文化Test plan
cmake --build --preset debug && ctest --preset debug)🤖 Generated with Claude Code