Fix heap buffer overflow in UDP engine out_event()#4906
Open
TristanInSec wants to merge 1 commit into
Open
Conversation
The out_event() send path copies group_size + body_size + 1 bytes into the fixed MAX_UDP_MSG (8192) byte _out_buffer without checking if the total exceeds the buffer capacity. Messages with body larger than approximately 7936 bytes overflow the buffer and corrupt adjacent heap memory. Add a bounds check before the memcpy calls, discarding oversized messages. This resolves the TODO comment that acknowledged the missing check. Signed-off-by: Tristan Music <tristmd@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
out_event()send path copiesgroup_size + body_size + 1bytes into the fixedMAX_UDP_MSG(8192) byte_out_bufferwithout checking if the total exceeds the buffer capacity. Messages with body larger than approximately 7936 bytes overflow the buffer and corrupt adjacent heap memory.This adds a bounds check before the
memcpycalls, discarding oversized messages. Resolves the TODO comment that acknowledged the missing check.