Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the PHP stack from version 7.4 to 8.2, bringing the codebase up to modern PHP standards with improved type safety and updated dependencies.
Key changes:
- PHP version requirement upgraded from 7.4 to 8.2
- Type hints added throughout the codebase (mixed, string, array, bool, void, static, nullable types)
- Breaking change: parameter order modified in
LicenseService::create()andLicenseService::update()methods - PHPUnit upgraded from 6.5 to 10.5 with updated configuration
- Dependencies updated (faker, php-cli-tools)
- CI/CD workflows modernized with PHP 8.2-8.4 testing matrix
Reviewed Changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updates PHP requirement to >=8.2 and modernizes dependencies (PHPUnit 10.5, fakerphp/faker, wp-cli/php-cli-tools) |
| phpunit.xml | Migrates to PHPUnit 10.5 configuration schema with updated attributes |
| common/Constants.php | Bumps version from 2.5.0 to 2.6.0 |
| README.md | Updates version reference and documentation link |
| vo/ValidationResults.php | Adds type hints (string, mixed) to methods |
| vo/ValidationParameters.php | Adds type hints with mixed return types for getter methods |
| vo/Page.php | Implements ArrayAccess interface methods with proper type hints |
| vo/Context.php | Adds type hints to magic methods (__set, __isset, __unset) and setValue |
| service/ValidationService.php | Adds mixed return type to retrieveValidationFile method |
| service/UtilityService.php | Updates filter parameter to nullable type syntax (?string) |
| service/TransactionService.php | Updates filter parameter to nullable type syntax |
| service/TokenService.php | Updates filter parameter to nullable type syntax |
| service/ProductService.php | Updates filter parameter to nullable type syntax |
| service/ProductModuleService.php | Updates filter parameter to nullable type syntax |
| service/PaymentMethodService.php | Updates filter parameter to nullable type syntax |
| service/NetLicensingService.php | Adds void return type to configure method |
| service/LicenseeService.php | Updates filter parameter to nullable type syntax |
| service/LicenseTemplateService.php | Updates filter parameter to nullable type syntax |
| service/LicenseService.php | Reorders parameters (breaking change) and updates filter parameter type |
| entity/traits/Properties.php | Adds comprehensive type hints including static return type and union types |
| entity/BaseEntity.php | Adds type hints to __set magic method |
| entity/LicenseTransactionJoin.php | Updates constructor parameters to nullable type syntax |
| demo/NetLicensingDemo.php | Updates calls to reflect parameter reordering and improves null handling |
| .gitignore | Adds .phpunit.cache directory |
| .travis.yml | Removes deprecated Travis CI configuration |
| .github/workflows/php.yml | Removes old GitHub Actions workflow |
| .github/workflows/netlicensing-php-dependency.yml | Removes old dependency test workflow |
| .github/netlicensing-php-dependabot.yml | Removes incomplete dependabot config |
| .github/dependabot.yml | Adds complete dependabot configuration for composer and GitHub Actions |
| .github/workflows/netlicensing-php-dependency-test.yml | Adds new dependency test workflow with PHP 8.4 |
| .github/workflows/netlicensing-php-demo.yml | Adds comprehensive demo test workflow for PHP 8.2-8.4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
r-brown
force-pushed
the
feature/AAV/upgrade-php-stack
branch
from
ee7499d to
e36ae3a
Compare
Contributor
This was referenced Nov 15, 2025
Contributor
* Initial plan * Add string type hint to TransactionService::get() $number parameter Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com>
* Initial plan * Add string type hint to PaymentMethodService::get() $number parameter Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 30 out of 31 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.