Add string type hint to PaymentMethodService::get() parameter#9
Merged
r-brown merged 2 commits intofeature/AAV/upgrade-php-stackfrom Nov 15, 2025
Merged
Conversation
Merged
Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Work in progress to address feedback on PHP stack upgrade PR
Add string type hint to PaymentMethodService::get() parameter
Nov 15, 2025
r-brown
approved these changes
Nov 15, 2025
r-brown
added a commit
that referenced
this pull request
Nov 15, 2025
* Upgrade NetLicensingClient-php library to support PHP v8.2 and higher * Fix demo * Fix security warnings * Revisit GitHub Actions * Prepare v2.6.0 * Copilot review * Add missing string type hint to TransactionService::get() parameter (#8) * Initial plan * Add string type hint to TransactionService::get() $number parameter Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com> * Add string type hint to PaymentMethodService::get() parameter (#9) * Initial plan * Add string type hint to PaymentMethodService::get() $number parameter Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com> * Update vo/ValidationParameters.php Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing
stringtype hint to$numberparameter inPaymentMethodService::get()for consistency with other service methods.Changes
PaymentMethodService::get()signature fromget(Context $context, $number)toget(Context $context, string $number)This aligns with the pattern used in
LicenseService::get(),ProductService::get(), andLicenseeService::get().💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.