Skip to content

Add string type hint to PaymentMethodService::get() parameter#9

Merged
r-brown merged 2 commits intofeature/AAV/upgrade-php-stackfrom
copilot/sub-pr-7-again
Nov 15, 2025
Merged

Add string type hint to PaymentMethodService::get() parameter#9
r-brown merged 2 commits intofeature/AAV/upgrade-php-stackfrom
copilot/sub-pr-7-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 15, 2025

Adds missing string type hint to $number parameter in PaymentMethodService::get() for consistency with other service methods.

Changes

  • Updated PaymentMethodService::get() signature from get(Context $context, $number) to get(Context $context, string $number)

This aligns with the pattern used in LicenseService::get(), ProductService::get(), and LicenseeService::get().


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Nov 15, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/FakerPHP/Faker/zipball/e0ee18eb1e6dc3cda3ce9fd97e5a0689a88a64b5
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/30JHah /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/Maks3w/xmldsig/zipball/e42980d022cede00f7ff34285e85db23cd89882a
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/30JHah /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/php-curl-class/php-curl-class/zipball/062f58613524947451efdb3dd7d7217719670a9f
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/30JHah /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/php-fig/container/zipball/c71ecc56dfe541dbd90c5360474fbc405f8d5963
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/30JHah /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/robrichards/xmlseclibs/zipball/2bdfd742624d739dfadbd415f00181b4a77aaf07
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/30JHah /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/sebastianbergmann/object-reflector/zipball/24ed13d98130f0e7122df55d06c5c4942a577957
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/30JHah /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/sebastianbergmann/type/zipball/462699a16464c3944eefc02ebdd77882bd3925bf
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/30JHah /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/sebastianbergmann/version/zipball/c51fa83a5d8f43f1402e3f32a005e6262244ef17
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/30JHah /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/symfony/deprecation-contracts/zipball/63afe740e99a13ba87ec199bb07bbdee937a5b62
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/30JHah /usr/bin/composer install --no-interaction (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Work in progress to address feedback on PHP stack upgrade PR Add string type hint to PaymentMethodService::get() parameter Nov 15, 2025
Copilot AI requested a review from r-brown November 15, 2025 09:06
@r-brown r-brown marked this pull request as ready for review November 15, 2025 09:08
@r-brown r-brown merged commit 8ed5f37 into feature/AAV/upgrade-php-stack Nov 15, 2025
6 checks passed
@r-brown r-brown deleted the copilot/sub-pr-7-again branch November 15, 2025 09:08
r-brown added a commit that referenced this pull request Nov 15, 2025
* Upgrade NetLicensingClient-php library to support PHP v8.2 and higher

* Fix demo

* Fix security warnings

* Revisit GitHub Actions

* Prepare v2.6.0

* Copilot review

* Add missing string type hint to TransactionService::get() parameter (#8)

* Initial plan

* Add string type hint to TransactionService::get() $number parameter

Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com>

* Add string type hint to PaymentMethodService::get() parameter (#9)

* Initial plan

* Add string type hint to PaymentMethodService::get() $number parameter

Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com>

* Update vo/ValidationParameters.php

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants