fix: XamlParseException due to missing ThemeResource fallback#910
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix: XamlParseException due to missing ThemeResource fallback#910sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
Windows.UI.Xaml.Markup.XamlParseExceptionthat occurred whenGridViewItemCheckBoxBorderBrushcould not be found, leading to application crashes on certain Windows/WinUI contract versions.The root cause was identified as the
GridViewItemCheckBoxBorderBrushbeing a systemThemeResourcethat is not universally available across all Windows/WinUI contract versions where thecontract13Presentstyle is applied. TheResourceDictionary.ThemeDictionariesinScreenbox/Styles/ItemContainer.xamllacked a fallbackStaticResourcedefinition for this key.To fix this,
StaticResourcefallbacks forGridViewItemCheckBoxBorderBrushhave been added to the Default, Light, and HighContrastThemeDictionarieswithinScreenbox/Styles/ItemContainer.xaml:ControlStrongStrokeColorDefaultBrush.SystemColorButtonTextColorBrush.This ensures that the XAML parser can always resolve the
GridViewItemCheckBoxBorderBrushresource, preventing theXamlParseExceptionand improving application stability across different Windows versions.Fixes SCREENBOX-32