Skip to content

fix: XamlParseException due to missing ThemeResource fallback #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: XamlParseException due to missing ThemeResource fallback #910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Screenbox/Styles/ItemContainer.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
<x:Double x:Key="TextFillColorSecondaryOpacity">0.775</x:Double>
<x:Double x:Key="TextFillColorTertiaryOpacity">0.53</x:Double>

<!-- Fallback for system ThemeResource that is missing on some Windows/WinUI contract versions -->
<StaticResource x:Key="GridViewItemCheckBoxBorderBrush" ResourceKey="ControlStrongStrokeColorDefaultBrush" />

<StaticResource x:Key="MediaGridViewItemBackgroundPointerOver" ResourceKey="ControlFillColorDefaultBrush" />
<StaticResource x:Key="MediaGridViewItemBackgroundPressed" ResourceKey="ControlAltFillColorTertiaryBrush" />
<StaticResource x:Key="MediaGridViewItemForegroundPointerOver" ResourceKey="TextFillColorPrimaryBrush" />
Expand All @@ -31,6 +34,9 @@
<x:Double x:Key="TextFillColorSecondaryOpacity">0.695</x:Double>
<x:Double x:Key="TextFillColorTertiaryOpacity">0.5</x:Double>

<!-- Fallback for system ThemeResource that is missing on some Windows/WinUI contract versions -->
<StaticResource x:Key="GridViewItemCheckBoxBorderBrush" ResourceKey="ControlStrongStrokeColorDefaultBrush" />

<StaticResource x:Key="MediaGridViewItemBackgroundPointerOver" ResourceKey="ControlFillColorDefaultBrush" />
<StaticResource x:Key="MediaGridViewItemBackgroundPressed" ResourceKey="LayerFillColorDefaultBrush" />
<StaticResource x:Key="MediaGridViewItemForegroundPointerOver" ResourceKey="TextFillColorPrimaryBrush" />
Expand All @@ -50,6 +56,9 @@
<x:Double x:Key="TextFillColorSecondaryOpacity">1</x:Double>
<x:Double x:Key="TextFillColorTertiaryOpacity">1</x:Double>

<!-- Fallback for system ThemeResource that is missing on some Windows/WinUI contract versions -->
<StaticResource x:Key="GridViewItemCheckBoxBorderBrush" ResourceKey="SystemColorButtonTextColorBrush" />

<StaticResource x:Key="MediaGridViewItemBackgroundPointerOver" ResourceKey="SystemColorHighlightTextColorBrush" />
<StaticResource x:Key="MediaGridViewItemBackgroundPressed" ResourceKey="SystemColorHighlightTextColorBrush" />
<StaticResource x:Key="MediaGridViewItemForegroundPointerOver" ResourceKey="SystemColorHighlightColorBrush" />
Expand Down
Loading