ACLP Logs SDK Pull request by klipensk · Pull Request #2359 · linode/terraform-provider-linode

klipensk · 2026-05-25T09:28:01Z

📝 Description

Adds Terraform support for the monitoring log destinations api and streams api.

✔️ How to Test

Unit tests:

log destinations API: make PKG_NAME=monitorlogsdestination test-unit
log streams API: make PKG_NAME=monitorlogsstream test-unit

Integration tests (package specific):

log destinations: LINODE_TOKEN=<your_token> make TEST_SUITE=monitorlogsdestination,monitorlogsdestinations test-int
log streams: LINODE_TOKEN=<your_token> RUN_LONG_TESTS=true TIMEOUT=300m make TEST_SUITE=monitorlogsdestination,monitorlogsdestinations,monitorlogsstream,monitorlogsstreams,monitorlogsstreamhistory test-int

Bumps [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2) from 1.98.0 to 1.100.1. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.98.0...service/s3/v1.100.1) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/s3 dependency-version: 1.100.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixed issues with integration tests * Fix lint * Ran go mod tidy

…e#2340) Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.40.0 to 2.40.1. - [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/v2.40.1/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-sdk@v2.40.0...v2.40.1) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-sdk/v2 dependency-version: 2.40.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Dps 42280 logs destination

Copilot

Pull request overview

This PR adds Terraform Framework support for Monitor Logs destinations and streams, including singular resources/data sources, list data sources, stream history lookup, acceptance/unit tests, provider registration, and CI suite wiring.

Changes:

Adds linode_monitor_logs_destination and linode_monitor_logs_stream resources with schema, CRUD, model flattening, templates, and tests.
Adds singular/list data sources for destinations and streams, plus a stream history data source.
Registers the new Terraform types and adds their integration suites to the workflow.

Reviewed changes

Copilot reviewed 52 out of 52 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`.github/workflows/integration_tests.yml`	Adds monitor logs suites and long-test env propagation.
`linode/framework_provider.go`	Registers new monitor logs resources and data sources.
`linode/monitorlogsdestination/framework_resource.go`	Implements destination resource CRUD.
`linode/monitorlogsdestination/framework_models.go`	Adds destination resource/data source models and flattening.
`linode/monitorlogsdestination/framework_schema_resource.go`	Defines destination resource schema.
`linode/monitorlogsdestination/framework_schema_datasource.go`	Defines singular destination data source schema.
`linode/monitorlogsdestination/framework_datasource.go`	Implements singular destination data source read.
`linode/monitorlogsdestination/framework_models_unit_test.go`	Adds destination model unit tests.
`linode/monitorlogsdestination/resource_test.go`	Adds destination resource acceptance tests.
`linode/monitorlogsdestination/datasource_test.go`	Adds destination data source acceptance tests.
`linode/monitorlogsdestination/tmpl/template.go`	Adds destination test template helpers.
`linode/monitorlogsdestination/tmpl/basic.gotf`	Adds destination basic resource test config.
`linode/monitorlogsdestination/tmpl/updates.gotf`	Adds destination update test config.
`linode/monitorlogsdestination/tmpl/bucket_only.gotf`	Adds bucket-only teardown config.
`linode/monitorlogsdestination/tmpl/data_basic.gotf`	Adds destination data source test config.
`linode/monitorlogsdestination/tmpl/data_not_found.gotf`	Adds destination not-found data source config.
`linode/monitorlogsdestination/tmpl/invalid_type.gotf`	Adds invalid destination type config.
`linode/monitorlogsdestinations/framework_datasource.go`	Implements list destination data source read/filtering.
`linode/monitorlogsdestinations/framework_models.go`	Adds list destination models.
`linode/monitorlogsdestinations/framework_schema_datasource.go`	Defines list destination data source schema/filter config.
`linode/monitorlogsdestinations/datasource_test.go`	Adds list destination data source acceptance test.
`linode/monitorlogsdestinations/tmpl/template.go`	Adds list destination test template helpers.
`linode/monitorlogsdestinations/tmpl/data_basic.gotf`	Adds list destination data source test config.
`linode/monitorlogsdestinations/tmpl/bucket_only.gotf`	Adds bucket-only teardown config.
`linode/monitorlogsstream/framework_resource.go`	Implements stream resource CRUD/import.
`linode/monitorlogsstream/framework_models.go`	Adds stream resource/data source models and options builders.
`linode/monitorlogsstream/framework_schema_resource.go`	Defines stream resource schema.
`linode/monitorlogsstream/framework_schema_datasource.go`	Defines singular stream data source schema.
`linode/monitorlogsstream/framework_datasource.go`	Implements singular stream data source read.
`linode/monitorlogsstream/framework_models_unit_test.go`	Adds stream model unit tests.
`linode/monitorlogsstream/resource_test.go`	Adds long-running stream lifecycle acceptance test and invalid config tests.
`linode/monitorlogsstream/datasource_test.go`	Adds stream data source not-found test.
`linode/monitorlogsstream/tmpl/template.go`	Adds stream test template helpers.
`linode/monitorlogsstream/tmpl/basic.gotf`	Adds stream basic resource test config.
`linode/monitorlogsstream/tmpl/lifecycle.gotf`	Adds stream lifecycle config covering related data sources.
`linode/monitorlogsstream/tmpl/updates.gotf`	Adds stream update config.
`linode/monitorlogsstream/tmpl/data_basic.gotf`	Adds singular stream data source config.
`linode/monitorlogsstream/tmpl/data_not_found.gotf`	Adds stream not-found data source config.
`linode/monitorlogsstream/tmpl/invalid_type.gotf`	Adds invalid stream type config.
`linode/monitorlogsstream/tmpl/invalid_destination.gotf`	Adds invalid destination config.
`linode/monitorlogsstreams/framework_datasource.go`	Implements list stream data source read/filtering.
`linode/monitorlogsstreams/framework_models.go`	Adds list stream models.
`linode/monitorlogsstreams/framework_schema_datasource.go`	Defines list stream data source schema/filter config.
`linode/monitorlogsstreams/datasource_test.go`	Adds skipped list stream data source test placeholder.
`linode/monitorlogsstreams/tmpl/template.go`	Adds list stream data source template helper.
`linode/monitorlogsstreams/tmpl/data_basic.gotf`	Adds list stream data source config.
`linode/monitorlogsstreamhistory/framework_datasource.go`	Implements stream history data source read.
`linode/monitorlogsstreamhistory/framework_models.go`	Adds stream history models and flattening.
`linode/monitorlogsstreamhistory/framework_schema_datasource.go`	Defines stream history data source schema.
`linode/monitorlogsstreamhistory/datasource_test.go`	Adds skipped stream history test placeholder.
`linode/monitorlogsstreamhistory/tmpl/template.go`	Adds stream history template helper.
`linode/monitorlogsstreamhistory/tmpl/data_basic.gotf`	Adds stream history data source config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

yec-akamai

Can you add documentations for the new resources and data sources under /docs?

klipensk · 2026-06-03T12:12:39Z

added docs #2359 (review)

…orkflows

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Signed-off-by: sjerecze <sjerecze@akamai.com>

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Clarify that 'cannot_delete_with_subresources' lock does not apply to 'lkecluster' or 'lkenodepool' entity types.

* Added support for optional root password in the linode_instance resource * Fix lint * Made root_pass optional for linode_instance_disk resource * Added support for boot_size and kernel fields * Address CoPilot feedback * Fix lint * Address PR comments

…ode#2362) Bumps [github.com/golangci/golangci-lint/v2](https://github.com/golangci/golangci-lint) from 2.11.4 to 2.12.2. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/main/CHANGELOG.md) - [Commits](golangci/golangci-lint@v2.11.4...v2.12.2) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint/v2 dependency-version: 2.12.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github.com/aws/aws-sdk-go-v2/credentials](https://github.com/aws/aws-sdk-go-v2) from 1.19.16 to 1.19.19. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@credentials/v1.19.16...credentials/v1.19.19) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/credentials dependency-version: 1.19.19 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…inode#2372)

…linode#2364) Bumps [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) from 1.41.9 to 1.41.11. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@v1.41.9...v1.41.11) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2 dependency-version: 1.41.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…inode#2367) Bumps [github.com/linode/linodego](https://github.com/linode/linodego) from 1.69.0 to 1.69.1. - [Release notes](https://github.com/linode/linodego/releases) - [Commits](linode/linodego@v1.69.0...v1.69.1) --- updated-dependencies: - dependency-name: github.com/linode/linodego dependency-version: 1.69.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…e#2363) Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4 to 5. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@v4...v5) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

GWrona and others added 16 commits May 8, 2026 14:00

[DPS-42280] [ACLP SDK] [Terraform] ACLP Logs destination API - draft

9ad27b7

Fixed various issues with integration tests (linode#2342)

10ed695

* Fixed issues with integration tests * Fix lint * Ran go mod tidy

[DPS-42280] [ACLP SDK] [Terraform] ACLP Logs destination API - tests

7139b17

ACLP Logs - Destination integration tests tweaks + extend units

5915308

ACLP Logs - Add negative integration test cases

7345a5b

Merge branch 'dev' into DPS-42280-logs-destination

4e8583e

ACLP Logs - fix framework_provider after merge

91dd4f4

ACLP Logs - Stabilize tests - fix integration tests cleanup fails

657469c

ACLP Logs - extend checkLogsDestinationDestroy assertion

45e1af5

ACLP Logs - stabilize tests - use explicit access keys for teardown

f886897

Apply suggestions from code review

9b30ba4

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

ACLP Logs - Review tweaks

439cab4

Merge pull request #1 from sjer-akamai/DPS-42280-logs-destination

884dd12

Dps 42280 logs destination

Merge branch 'linode:dev' into dev

fc3a0c8

klipensk requested review from a team as code owners May 25, 2026 09:28

klipensk requested review from psnoch-akamai and yec-akamai and removed request for a team May 25, 2026 09:28

sjer-akamai force-pushed the dev branch 2 times, most recently from 33d0b4a to a2f18a1 Compare May 25, 2026 14:00

yec-akamai requested a review from Copilot May 31, 2026 18:31

Copilot started reviewing on behalf of yec-akamai May 31, 2026 18:31 View session

Copilot AI reviewed May 31, 2026

View reviewed changes

Comment thread linode/framework_provider.go

Comment thread linode/monitorlogsstreams/datasource_test.go

Comment thread linode/monitorlogsstreamhistory/datasource_test.go

Comment thread linode/monitorlogsstream/framework_resource.go

yec-akamai reviewed Jun 2, 2026

View reviewed changes

Comment thread linode/monitorlogsdestination/framework_schema_resource.go Outdated

yec-akamai added community-contribution for contributions made by a non-DX author new-feature for new features in the changelog. labels Jun 2, 2026

klipensk requested a review from yec-akamai June 3, 2026 12:13

klipensk changed the title ~~[DPS-42656] [ACLP SDK][Terraform] ACLP Logs SDK Pull request~~ ACLP Logs SDK Pull request Jun 3, 2026

klipensk and others added 21 commits June 24, 2026 09:51

[DPS-42282] [ACLP SDK] [Terraform] ACLP Logs Stream API

ca12d0d

[DPS-42282] [ACLP SDK] [Terraform] ACLP Logs Stream API

964da13

[DPS-42282] [ACLP SDK] [Terraform] ACLP Logs Stream API - ci and pr w…

ff07956

…orkflows

[DPS-42282] [ACLP SDK] [Terraform] ACLP Logs Stream API - pr fixes

d062934

[DPS-42282] [ACLP SDK] [Terraform] ACLP Logs Stream API - pr fixes

337a18b

Potential fix for pull request finding

cc4f424

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

f073452

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

ACLP Logs destination - fix unit tests

d9f01da

Signed-off-by: sjerecze <sjerecze@akamai.com>

Potential fix for pull request finding

e540902

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

[ACLP SDK][Terraform] ACLP Logs SDK Pull request - fixes

c5a21f5

[ACLP SDK][Terraform] ACLP Logs SDK Pull request - workflow fixes

84b381e

Update lock.md to clarify lock_type limitations (linode#2343)

8a54ac4

Clarify that 'cannot_delete_with_subresources' lock does not apply to 'lkecluster' or 'lkenodepool' entity types.

Fixed integration tests broken by SLADE/CLEO changes (linode#2370)

ce38495

Removed plan validation for auth fields in favor of apply validation (l…

2b1d007

…inode#2372)

Merge branch 'linode:dev' into dev

7904216

sjer-akamai force-pushed the dev branch from e6dd2d7 to 4b0970f Compare June 24, 2026 07:53

Merge branch 'GWrona:dev' into dev

4573e30

sjer-akamai force-pushed the dev branch from b3ca4ad to 4573e30 Compare June 25, 2026 07:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ACLP Logs SDK Pull request#2359

ACLP Logs SDK Pull request#2359
klipensk wants to merge 38 commits into
linode:devfrom
sjer-akamai:dev

klipensk commented May 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yec-akamai left a comment

Uh oh!

Uh oh!

klipensk commented Jun 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

klipensk commented May 25, 2026

📝 Description

✔️ How to Test

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yec-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

klipensk commented Jun 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants