Prepare Go GitHub action#10709
Merged
Merged
Conversation
stephanos
commented
Jun 15, 2026
| # Cache restore can miss modules after go.sum changes or partial cache saves. | ||
| # Retrying download here isolates transient Go proxy failures from the Go command. | ||
| - name: Download Go modules | ||
| uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0 |
Contributor
Author
There was a problem hiding this comment.
This was the reason for of the change
stephanos
force-pushed
the
stephanos/retry-go-download
branch
4 times, most recently
from
addd5dd to
a78e947
Compare
stephanos
commented
Jun 15, 2026
| path: ~/.cache/go-build | ||
| key: go-${{ runner.os }}${{ runner.arch }}-${{ steps.setup-go.outputs.go-version }}-build-${{ env.COMMIT }} | ||
| restore-keys: | | ||
| go-${{ runner.os }}${{ runner.arch }}-${{ steps.setup-go.outputs.go-version }}-build- |
Contributor
Author
There was a problem hiding this comment.
Drive-by improvement; we restore previous cache to increase cache hit likelihood instead of starting from scratch. This is safe in Go as its build outputs are content-addressed.
stephanos
commented
Jun 15, 2026
| uses: actions/cache/restore@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5 | ||
| with: | ||
| path: ~/.cache/go-build | ||
| key: go-${{ runner.os }}${{ runner.arch }}-${{ steps.setup-go.outputs.go-version }}-build-${{ env.COMMIT }} |
Contributor
Author
There was a problem hiding this comment.
Drive-by improvement; key cache to include Go version, too. A stale cache with an old version is useless.
stephanos
force-pushed
the
stephanos/retry-go-download
branch
5 times, most recently
from
517cec8 to
0d2ccf9
Compare
stephanos
commented
Jun 15, 2026
| path: ${{ steps.go-env.outputs.gomodcache }} | ||
| key: go-${{ runner.os }}${{ runner.arch }}-${{ steps.setup-go.outputs.go-version }}-${{ hashFiles('go.mod') }}-deps-${{ hashFiles('go.sum') }} | ||
|
|
||
| - name: Restore Go tools |
Contributor
Author
There was a problem hiding this comment.
Drive-by improvement; save some seconds by caching the .bin folder
stephanos
force-pushed
the
stephanos/retry-go-download
branch
from
0d2ccf9 to
65081e2
Compare
stephanos
commented
Jun 15, 2026
Comment on lines
+46
to
+47
| echo "gocache=$(go env GOCACHE)" >> "$GITHUB_OUTPUT" | ||
| echo "gomodcache=$(go env GOMODCACHE)" >> "$GITHUB_OUTPUT" |
Contributor
Author
There was a problem hiding this comment.
No longer hard-coded
stephanos
commented
Jun 15, 2026
| # This should use the same build flags as functional-test-coverage and functional-test-{xdc,ndc}-coverage for best build caching. | ||
| pre-build-functional-test-coverage: prepare-coverage-test | ||
| go test -c -cover -o /dev/null $(FUNCTIONAL_TEST_ROOT) $(TEST_ARGS) $(TEST_TAG_FLAG) $(COVERPKG_FLAG) | ||
| go test -c -cover -o /dev/null $(COMPILED_TEST_ARGS) $(COVERPKG_FLAG) $(FUNCTIONAL_TEST_ROOT) |
Contributor
Author
There was a problem hiding this comment.
COMPILED_TEST_ARGS ensures that the cache this produces matches what the functional tests need; otherwise there's a cache mismatch
stephanos
force-pushed
the
stephanos/retry-go-download
branch
from
09d8f9e to
a0789aa
Compare
stephanos
force-pushed
the
stephanos/retry-go-download
branch
from
a0789aa to
d92297e
Compare
chaptersix
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added an explicit
go downloadstep with retry.Extracted a new GitHub action for the "setup Go" steps across test jobs; to reduce duplication.
Why?
Sometimes the
go downloadfails and could be retried: https://github.com/temporalio/temporal/actions/runs/27560870829/job/81473394249?pr=9160Also; pre-build is now faster.
It is usually 1-2min.